Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to_h to the class used for ENV #3218

Merged
merged 2 commits into from Aug 6, 2015

Conversation

Projects
None yet
2 participants
@reuben-sutton
Copy link
Contributor

reuben-sutton commented Aug 3, 2015

That makes it so that it duplicates rather than returning the same object to make compatible with MRI

fixes #3162

@reuben-sutton reuben-sutton force-pushed the reuben-sutton:make_env_to_h_dup branch from f270b34 to 4fad5de Aug 3, 2015

@kares

This comment has been minimized.

Copy link
Member

kares commented Aug 4, 2015

change seem to introduce a failure e.g. here https://travis-ci.org/jruby/jruby/jobs/73959532#L3277-L3284

@reuben-sutton

This comment has been minimized.

Copy link
Contributor Author

reuben-sutton commented Aug 4, 2015

@kares So it does. Doesn't happen on oraclejdk8, so installing openjdk7 to see if I can reproduce there.

@reuben-sutton

This comment has been minimized.

Copy link
Contributor Author

reuben-sutton commented Aug 4, 2015

hi @kares - just found the issue and committed a fix.

@kares

This comment has been minimized.

Copy link
Member

kares commented Aug 5, 2015

since this is rubyspecs your updating it needs a certain level of quality, you seem to set ENV['foo'] for no reason ... either assert smt around it (maybe even change the key name to not collide with another spec) or simply remove the first/last lines.

we also need the spec change to be in separate commits (so it can be easy ported upstream), thus please update your commits to be clean (one fixinig to_h another one adding a spec)

@reuben-sutton reuben-sutton force-pushed the reuben-sutton:make_env_to_h_dup branch from 1014fd0 to f1b442d Aug 5, 2015

@reuben-sutton reuben-sutton force-pushed the reuben-sutton:make_env_to_h_dup branch from f1b442d to cbd7296 Aug 5, 2015

@reuben-sutton

This comment has been minimized.

Copy link
Contributor Author

reuben-sutton commented Aug 5, 2015

Hi @kares, that's done. Thanks!

@kares

This comment has been minimized.

Copy link
Member

kares commented Aug 5, 2015

@reuben-sutton excellent, thanks! this should be good to go - we're just wait to hear about travis-ci (no worries about unrelated failures)

kares added a commit that referenced this pull request Aug 6, 2015

Merge pull request #3218 from reuben-sutton/make_env_to_h_dup
add to_h to the class used for ENV

@kares kares merged commit 3ff99ce into jruby:master Aug 6, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@kares kares added this to the JRuby 9.0.1.0 milestone Aug 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.