Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Digest bubblebabble incorrect output on empty string #3238

Merged
merged 1 commit into from Aug 12, 2015

Conversation

@kubum
Copy link
Contributor

@kubum kubum commented Aug 9, 2015

Hey guys

Before:

bin/jruby -rdigest -e "p Digest.bubblebabble ''"
"xx"

After:

bin/jruby -rdigest -e "p Digest.bubblebabble ''"
"xexax"

MRI:

ruby -rdigest/bubblebabble -e "p Digest.bubblebabble ''"
"xexax"

and http://web.mit.edu/kenta/www/one/bubblebabble/spec/jrtrjwzi/draft-huima-01.txt

Test Vectors

ASCII Input Encoding

' (empty string)xexax'

Fixes #2956

Before:

bin/jruby -rdigest -e "p Digest.bubblebabble ''"
"xx"

After:

bin/jruby -rdigest -e "p Digest.bubblebabble ''"
"xexax"
@kubum
Copy link
Contributor Author

@kubum kubum commented Aug 12, 2015

Hi @chrisseaton

What do you think about this PR? :)

chrisseaton added a commit that referenced this pull request Aug 12, 2015
Fix Digest bubblebabble incorrect output on empty string
@chrisseaton chrisseaton merged commit 5e3e186 into jruby:master Aug 12, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@chrisseaton chrisseaton added this to the JRuby 9.0.1.0 milestone Aug 12, 2015
@chrisseaton chrisseaton self-assigned this Aug 12, 2015
@kares
Copy link
Member

@kares kares commented Aug 12, 2015

... kept this open as this could use some more work, currently require 'digest/bubblebabble' blows

@chrisseaton
Copy link
Contributor

@chrisseaton chrisseaton commented Aug 12, 2015

Wow that's strange - it's such a simple change and I thought all the tests were passing (apart from the Truffle MRI tests apparently but they are unrelated).

@kares
Copy link
Member

@kares kares commented Aug 12, 2015

@chrisseaton sorry it does pass, still compatibility is not "ideal" since the require should work ...
I'll just open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants