Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix #276. For good. #324

Merged
merged 1 commit into from

2 participants

Sébastien Le Callonnec Charles Oliver Nutter
Sébastien Le Callonnec
Collaborator

RuntimeHelpers.unsplatValue19IfArityOne must be assigned back to argsResult for the refactor to work.

This fixes related tests:

➈❸ greystones:~/dev/jruby (gh276)$ ./bin/jruby -I"lib:test" test/externals/ruby1.9/test_pp.rb -n "test_hash_with_boolean_value"
Run options: -n test_hash_with_boolean_value

# Running tests:

.

Finished tests in 0.086000s, 11.6279 tests/s, 11.6279 assertions/s.

1 tests, 1 assertions, 0 failures, 0 errors, 0 skips
➈❸ greystones:~/dev/jruby (gh276)$ ./bin/jruby -S rspec spec/regression/GH-276_yield_splat_behaviour_causes_pp_to_break.rb 
.....

Finished in 0.022 seconds
5 examples, 0 failures

Charles Oliver Nutter headius merged commit 46399a1 into from
Charles Oliver Nutter
Owner

I admire your confidence :) Merged the PR in; compiler seems to already be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 29, 2012
  1. Sébastien Le Callonnec

    Fix #276.

    tychobrailleur authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/org/jruby/ast/Yield19Node.java
2  src/org/jruby/ast/Yield19Node.java
View
@@ -30,7 +30,7 @@ public IRubyObject interpret(Ruby runtime, ThreadContext context, IRubyObject se
case ARGSPUSHNODE:
case ARGSCATNODE:
case SPLATNODE:
- RuntimeHelpers.unsplatValue19IfArityOne(argsResult, yieldToBlock);
+ argsResult = RuntimeHelpers.unsplatValue19IfArityOne(argsResult, yieldToBlock);
break;
case ARRAYNODE:
// Pass-thru
Something went wrong with that request. Please try again.