backport #3271, #3211, #3221 #3278

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Projects
None yet
2 participants
@ahorek
Contributor

ahorek commented Aug 23, 2015

No description provided.

@enebo enebo added this to the JRuby 1.7.23 milestone Aug 24, 2015

@enebo enebo added the core label Aug 24, 2015

enebo added a commit that referenced this pull request Aug 24, 2015

@enebo enebo merged commit c55a162 into jruby:jruby-1_7 Aug 24, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

enebo added a commit that referenced this pull request Mar 17, 2016

Fixes #3278: File.open w/ File::RDWR should write \r\n but gets should
read as \n after rewind on windows.

We were missing some windows-specific logic in needsWriteConversion.  With
this change I get three more specs passing and no regression on MRI test
suite.  SHIP IT...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment