only new up kernel32 instance once per jvm #329

Merged
merged 3 commits into from Oct 5, 2012

Conversation

Projects
None yet
2 participants
@rdp
Contributor

rdp commented Oct 2, 2012

as requested by Wayne.

@rdp

This comment has been minimized.

Show comment
Hide comment
@rdp

rdp Oct 2, 2012

Owner

ok check out a2dee63
is it possible to fail to load kernel32 here?
Thanks!

Owner

rdp commented on 7fbf911 Oct 2, 2012

ok check out a2dee63
is it possible to fail to load kernel32 here?
Thanks!

@rdp

This comment has been minimized.

Show comment
Hide comment
@rdp

rdp Oct 2, 2012

Owner

This comment has been minimized.

Show comment
Hide comment
@rdp

rdp Oct 3, 2012

Owner
Owner

rdp replied Oct 3, 2012

@rdp

This comment has been minimized.

Show comment
Hide comment
@rdp

rdp Oct 3, 2012

Owner

ok @headius I believe the https://github.com/rdp/jruby/tree/static_kernel32 branch is ready to merge, see jruby#329

Owner

rdp commented on 2809816 Oct 3, 2012

ok @headius I believe the https://github.com/rdp/jruby/tree/static_kernel32 branch is ready to merge, see jruby#329

BanzaiMan added a commit that referenced this pull request Oct 5, 2012

Merge pull request #329 from rdp/static_kernel32
only new up kernel32 instance once per jvm

@BanzaiMan BanzaiMan merged commit 2b6f396 into jruby:master Oct 5, 2012

1 check passed

default The Travis build passed
Details
@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Oct 5, 2012

Member

@wmeissner Did you try merging? I checked the permissions, and I believe you can.

Member

BanzaiMan commented Oct 5, 2012

@wmeissner Did you try merging? I checked the permissions, and I believe you can.

@rdp

This comment has been minimized.

Show comment
Hide comment
@rdp

rdp Oct 11, 2012

Contributor

thanks @wmeissner and @BanzaiMan

Contributor

rdp commented Oct 11, 2012

thanks @wmeissner and @BanzaiMan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment