/jruby

return UTC instead of GMT (fixes #3304) #3310

Merged
merged 1 commit into from Sep 8, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  Non-Release
3 participants
@tdaitx @mkristian @enebo
@tdaitx
Contributor

tdaitx commented Sep 4, 2015

As per Ruby's Time#zone [1] UTC should be used instead of GMT
since Ruby 1.8. The spec also expects UTC.

spec/ruby/core/time/zone_spec.rb:

  it "returns UTC when called on a UTC time" do
    Time.now.utc.zone.should == "UTC"
  end

This also fixes #3304.

[1] http://ruby-doc.org/core-2.2.3/Time.html#method-i-zone
@tdaitx
return UTC instead of GMT (fixes #3304) 
As per Ruby's Time#zone [1] UTC should be used instead of GMT
since Ruby 1.8. This also fixes #3304.

[1] http://ruby-doc.org/core-2.2.3/Time.html#method-i-zone
b681987

@tdaitx tdaitx referenced this pull request Sep 4, 2015

Closed

zone_spec.rb fails SPEC test "Time#zone returns UTC when called on a UTC time" #3304

mkristian added a commit that referenced this pull request Sep 8, 2015

@mkristian
Merge pull request #3310 from tdaitx/fix-3304-return-utc 
return UTC instead of GMT (fixes #3304)
0596e57

@mkristian mkristian merged commit 0596e57 into jruby:master Sep 8, 2015
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@enebo enebo modified the milestone: Non-Release May 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment