Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for aliasing Java indexed getters as Ruby readers #3328

Merged
merged 1 commit into from Nov 13, 2015

Conversation

@kares
Copy link
Member

@kares kares commented Sep 15, 2015

fixes #3262 ... its a non-backward compatible change thus fired up here to decide

#3262)

a rarely (if ever used) feature that looks a bit weird and was "not-complete" 
(indexed setters do not receive a special treat) and never documented
@enebo
Copy link
Member

@enebo enebo commented Oct 15, 2015

I am willing to break this and see if anyone has ever happened across this syntax. I know we never wrote about it in our book. We also have no specs. The original code was landed in 2007 along with our first JI JavaBean shorthand. I am going to wait until 9.0.3.0 just so we can accidentally stumble over someone using this instead of doing it a day or two before release.

@enebo enebo modified the milestones: JRuby 9.0.3.0, JRuby 9.0.2.0 Oct 15, 2015
@enebo
Copy link
Member

@enebo enebo commented Oct 15, 2015

Oh unless anyone else thinks this is being used...Obviously we do not want to break code but this is so unknown none of us knew it even existed...

@enebo enebo modified the milestones: JRuby 9.0.3.0, JRuby 9.0.4.0 Oct 21, 2015
@enebo enebo modified the milestones: JRuby 9.0.4.0, JRuby 9.0.5.0 Nov 13, 2015
kares added a commit that referenced this pull request Nov 13, 2015
remove support for aliasing Java indexed getters as Ruby readers
@kares kares merged commit 6379615 into master Nov 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kares kares deleted the test-remove-get-indexed-reader-alias branch Nov 13, 2015
@rosenfeld
Copy link

@rosenfeld rosenfeld commented Apr 13, 2016

My code used this since I thought it was supported on purpose and it broke when I upgraded JRuby to 9.0.5.0 from 1.7.11 I think. But that's okay, a few changes and I got it back to work. Just having some issues with latest RSpec since sometimes exception.backtrace is nil in JRuby for some reason...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants