/ jruby Public
Fix java_implements for multiple interfaces #3330
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Matching fix for ##3329 for the 9.x master branch.
Using multiple interfaces with java_implements is broken, and the specs that tests for this are also broken. This fixes it.
It also appears that many of the jrubyc specs are broken enough though they pass. Those are not fixed here. In general, it appears the specs attempt to do a regexp match against the generated Java code, but the tests pass not because the generated code is correct, but because the generated code includes a copy of the spec source code in the
sourcevariable. Thus, the regexp is matching itself and not the generated Java code.
It would appear that the call to
JRuby::Compiler::JavaGenerator.generate_javaresults in the whole spec being included in the
sourcevariable rather than just the source for the Ruby code being compiled to Java.