New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public org.jruby.Runtime.Profile.Builtin::MethodData #3383

Merged
merged 3 commits into from Oct 26, 2016

Conversation

Projects
None yet
4 participants
@kml

kml commented Oct 10, 2015

this makes building custom tooling easier

http://pastebin.com/XhNYdMtD

kml added some commits Oct 10, 2015

public InvocationSet
"InvocationSet is not public in org.jruby.runtime.profile.builtin; cannot be accessed from outside package"
@kml

This comment has been minimized.

Show comment
Hide comment
@kml

kml Oct 11, 2015

Thanks to changing visiblity I can compile my modified copies of all default ProfilePrinters.
If it does not make sense to accept all those changes please ignore the PR.

kml commented Oct 11, 2015

Thanks to changing visiblity I can compile my modified copies of all default ProfilePrinters.
If it does not make sense to accept all those changes please ignore the PR.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 15, 2015

at least this one should have a public getter instead

at least this one should have a public getter instead

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 15, 2015

Member

originally those package-protected classes were hidden on purpose as they were not polished.
but assuming no API review is about to happen soon its probably fine ... as a semi-official API :)
actually the profiling Java API did get polished at: c58164f

Member

kares commented Oct 15, 2015

originally those package-protected classes were hidden on purpose as they were not polished.
but assuming no API review is about to happen soon its probably fine ... as a semi-official API :)
actually the profiling Java API did get polished at: c58164f

@BanzaiMan BanzaiMan closed this May 17, 2016

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 18, 2016

Member

@kares was this closed by mistake?

Member

headius commented May 18, 2016

@kares was this closed by mistake?

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares May 19, 2016

Member

@headius seems like it might have been ... re-opening (@BanzaiMan feel free to close with feedback)

Member

kares commented May 19, 2016

@headius seems like it might have been ... re-opening (@BanzaiMan feel free to close with feedback)

@kml

This comment has been minimized.

Show comment
Hide comment
@kml

kml May 19, 2016

From my perspective I don't need this right now.
I've done profiling using patched version of jruby and I'm not sure if anyone else need it.

kml commented May 19, 2016

From my perspective I don't need this right now.
I've done profiling using patched version of jruby and I'm not sure if anyone else need it.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 26, 2016

Member

these are still valid (even in 9K's context), although some of the stuff such as making fields public might be seen as internals and thus subject to change. believe there's no reason not to merge.

Member

kares commented Oct 26, 2016

these are still valid (even in 9K's context), although some of the stuff such as making fields public might be seen as internals and thus subject to change. believe there's no reason not to merge.

@kares kares merged commit 9d9a2f8 into jruby:jruby-1_7 Oct 26, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@kares kares modified the milestones: JRuby 1.7.27, JRuby 1.7.26 Oct 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment