[Truffle] make j+tr part of the distribution #3412

Merged
merged 1 commit into from Nov 17, 2015

Conversation

Projects
None yet
5 participants
@pitr-ch
Member

pitr-ch commented Oct 22, 2015

No description provided.

@pitr-ch pitr-ch added the truffle label Oct 22, 2015

@pitr-ch pitr-ch self-assigned this Oct 22, 2015

@pitr-ch pitr-ch added this to the truffe milestone Oct 22, 2015

bin/jruby+truffle.bat
@@ -0,0 +1 @@
+echo Windows are not yet supported by jruby+truffle.

This comment has been minimized.

@nirvdrum

nirvdrum Oct 22, 2015

Contributor

English is weird. You really want to say "Windows is not" here because it's a singular item referring to the name of the operating system.

@nirvdrum

nirvdrum Oct 22, 2015

Contributor

English is weird. You really want to say "Windows is not" here because it's a singular item referring to the name of the operating system.

This comment has been minimized.

@eregon

eregon Oct 22, 2015

Member

is, no?

@eregon

eregon Oct 22, 2015

Member

is, no?

bin/jruby+truffle
+
+require 'jruby+truffle/runner'
+
+JRubyTruffleRunner.new

This comment has been minimized.

@eregon

eregon Oct 22, 2015

Member

How is this going to work? you need a require_relative I think.

@eregon

eregon Oct 22, 2015

Member

How is this going to work? you need a require_relative I think.

This comment has been minimized.

@pitr-ch

pitr-ch Oct 22, 2015

Member

The runner file is on the same path as stdlib so it always available in jruby.

@pitr-ch

pitr-ch Oct 22, 2015

Member

The runner file is on the same path as stdlib so it always available in jruby.

This comment has been minimized.

@eregon

eregon Oct 23, 2015

Member

But what if I want to run it with MRI?

@eregon

eregon Oct 23, 2015

Member

But what if I want to run it with MRI?

@nirvdrum

This comment has been minimized.

Show comment
Hide comment
@nirvdrum

nirvdrum Oct 22, 2015

Contributor

Looks good.

Contributor

nirvdrum commented Oct 22, 2015

Looks good.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Oct 22, 2015

Member

looks good for me as well. but I really would like to hear some comment from @headius and @enebo about adding this to ./lib/ruby/stdlib

Member

mkristian commented Oct 22, 2015

looks good for me as well. but I really would like to hear some comment from @headius and @enebo about adding this to ./lib/ruby/stdlib

@mkristian mkristian modified the milestones: JRuby 9.0.5.0, truffe Oct 23, 2015

@mkristian mkristian added the stdlib label Oct 23, 2015

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Oct 30, 2015

Member

@enebo @headius: is this too invasive, or can it be merged?

Member

pitr-ch commented Oct 30, 2015

@enebo @headius: is this too invasive, or can it be merged?

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Nov 5, 2015

Member

@pitr-ch is there any reason this cannot be in lib/ruby/truffle? stdlib is mostly for files which are in MRI's stdlib. I think we have some variants like jossl (although I think this is a mistake) but mostly those variants are working around differences between MRI and JRuby.

Member

enebo commented Nov 5, 2015

@pitr-ch is there any reason this cannot be in lib/ruby/truffle? stdlib is mostly for files which are in MRI's stdlib. I think we have some variants like jossl (although I think this is a mistake) but mostly those variants are working around differences between MRI and JRuby.

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Nov 8, 2015

Member

@enebo This tool is suppose to be loaded in JRuby it can prepare environment to run files with gems in JRuby+Truffle and then run files in the prepared environment. The tool always runs in JRuby it computes required options and then it executes JRuby+Truffle with them. If it is in lib/ruby/truffle it won't be visible to JRuby.

Member

pitr-ch commented Nov 8, 2015

@enebo This tool is suppose to be loaded in JRuby it can prepare environment to run files with gems in JRuby+Truffle and then run files in the prepared environment. The tool always runs in JRuby it computes required options and then it executes JRuby+Truffle with them. If it is in lib/ruby/truffle it won't be visible to JRuby.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Nov 9, 2015

Member

@pitr-ch as I understand it, the tool is executes exclusively via the bin/jruby+truffle

so instead of https://github.com/jruby/jruby/pull/3412/files#diff-0e9caaa4ef2b36ca7f4ea6308854ebd7R3
you could use something like

require File.join(JRuby.runtime.instance_config.jruby_home, 'lib/ruby/truffle/jruby+truffle/runner')
Member

mkristian commented Nov 9, 2015

@pitr-ch as I understand it, the tool is executes exclusively via the bin/jruby+truffle

so instead of https://github.com/jruby/jruby/pull/3412/files#diff-0e9caaa4ef2b36ca7f4ea6308854ebd7R3
you could use something like

require File.join(JRuby.runtime.instance_config.jruby_home, 'lib/ruby/truffle/jruby+truffle/runner')
@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Nov 9, 2015

Member

@mkristian ah thanks for the suggestion. Sounds good, I'll update the PR.

Member

pitr-ch commented Nov 9, 2015

@mkristian ah thanks for the suggestion. Sounds good, I'll update the PR.

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Nov 17, 2015

Member

@mkristian @enebo updated and ready for merge.

Member

pitr-ch commented Nov 17, 2015

@mkristian @enebo updated and ready for merge.

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Nov 17, 2015

Member

I think travis does not really run into this change. merging.

Member

mkristian commented Nov 17, 2015

I think travis does not really run into this change. merging.

mkristian added a commit that referenced this pull request Nov 17, 2015

Merge pull request #3412 from pitr-ch/master
[Truffle] make j+tr part of the distribution

@mkristian mkristian merged commit 42c4a2c into jruby:master Nov 17, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Nov 18, 2015

Member

@pitr-ch thanx for all this shifting around a second time

Member

mkristian commented Nov 18, 2015

@pitr-ch thanx for all this shifting around a second time

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Nov 18, 2015

Member

No problem at all @mkristian. I was a better option.

Member

pitr-ch commented Nov 18, 2015

No problem at all @mkristian. I was a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment