New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.3's #dig #3458

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
@kares
Member

kares commented Nov 12, 2015

[].dig(0) and {}.dig(:a) as introduced by MRI 2.3.0.preview1

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Nov 13, 2015

Member

@kares Nice work and specs here!
Could you make a PR against ruby/rubyspec?
That would avoid a possible spec duplication and to test the specs on multiple MRI versions 😃
I can then merge quickly the specs back to jruby master.

Member

eregon commented Nov 13, 2015

@kares Nice work and specs here!
Could you make a PR against ruby/rubyspec?
That would avoid a possible spec duplication and to test the specs on multiple MRI versions 😃
I can then merge quickly the specs back to jruby master.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 13, 2015

Member

@eregon thx, I thought the work-flow is that you pick those eventually back to ruby/rubyspec.
so than I should remove those [rubyspec] commits from here ? ... also not sure how long this would be open before getting merged - maybe its only to be commited after 2.3 final as JRuby 9.1 will come out

Member

kares commented Nov 13, 2015

@eregon thx, I thought the work-flow is that you pick those eventually back to ruby/rubyspec.
so than I should remove those [rubyspec] commits from here ? ... also not sure how long this would be open before getting merged - maybe its only to be commited after 2.3 final as JRuby 9.1 will come out

@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Nov 13, 2015

Member

@kares For new feature specs I think it's more beneficial to PR against the ruby/rubyspec repo.
Specs for existing stuff is less critical and can more easily be merged later.
Also, this allows to tweak the spec while it's getting stable in MRI.

A guard of minimal version 2.3 will be needed anyway for this spec to pass on older versions, so this spec will only run when JRuby declares RUBY_VERSION to be "2.3.x" (it's possible to ignore such a guard with --unguarded while developing).

Yes, please remove them from here if you do the PR so there is no chance for conflict :)

Member

eregon commented Nov 13, 2015

@kares For new feature specs I think it's more beneficial to PR against the ruby/rubyspec repo.
Specs for existing stuff is less critical and can more easily be merged later.
Also, this allows to tweak the spec while it's getting stable in MRI.

A guard of minimal version 2.3 will be needed anyway for this spec to pass on older versions, so this spec will only run when JRuby declares RUBY_VERSION to be "2.3.x" (it's possible to ignore such a guard with --unguarded while developing).

Yes, please remove them from here if you do the PR so there is no chance for conflict :)

lambda { [10].dig() }.should raise_error(ArgumentError)
end
end

This comment has been minimized.

@benlovell

benlovell Nov 13, 2015

Contributor

Missing a terminating newline character here.

@benlovell

benlovell Nov 13, 2015

Contributor

Missing a terminating newline character here.

@kares kares referenced this pull request Nov 15, 2015

Merged

Ruby 2.3's #dig #161

@kares kares added this to the JRuby 9.1.0.0 milestone Nov 21, 2015

@kares kares added the ruby 2.3 label Nov 21, 2015

@headius headius referenced this pull request Nov 21, 2015

Closed

Ruby 2.3 support #3479

50 of 58 tasks complete
@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Nov 21, 2015

Member

put the commits into ruby-2.3 which should merge to master after 2.3 final when 9.1.0 is released

Member

kares commented Nov 21, 2015

put the commits into ruby-2.3 which should merge to master after 2.3 final when 9.1.0 is released

@kares kares closed this Nov 21, 2015

@headius headius deleted the test-2.3-dig branch Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment