New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Coverage.peek_result #3481

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@tenderlove
Contributor

tenderlove commented Nov 20, 2015

This patch implements Coverage.peek_result that was implemented in MRI
here:

https://bugs.ruby-lang.org/issues/10816

I didn't add any tests because there are test in the MRI suite that cover this. Also, I admit that I haven't run the JRuby tests but it does compile? ¯_(⊙︿⊙)_/¯

implement Coverage.peek_result
This patch implements `Coverage.peek_result` that was implemented in MRI
here:

  https://bugs.ruby-lang.org/issues/10816
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Nov 20, 2015

Member

We run the MRI tests and will be updating them for 2.3 as we wrap up behavioral changes. In any case, the change is pretty small.

Member

headius commented Nov 20, 2015

We run the MRI tests and will be updating them for 2.3 as we wrap up behavioral changes. In any case, the change is pretty small.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Nov 20, 2015

Member

Merged to ruby-2.3 in ced60e8. We'll merge to master for 9.1.0.0.

Member

headius commented Nov 20, 2015

Merged to ruby-2.3 in ced60e8. We'll merge to master for 9.1.0.0.

@headius headius closed this Nov 20, 2015

@headius headius added this to the JRuby 9.1.0.0 milestone Nov 20, 2015

@headius headius referenced this pull request Nov 20, 2015

Closed

Ruby 2.3 support #3479

50 of 58 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment