New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick change to add support for jruby on msys/mingw #37

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jasonkarns
Contributor

jasonkarns commented May 25, 2011

This change simply executes the jruby.exe (passing along any arguments) when 'jruby' is called from mingw. It then exits with the returned code from jruby.exe.

@jstoneham

This comment has been minimized.

Show comment
Hide comment
@jstoneham

jstoneham Jun 8, 2011

I was about to create a pull request that made things work under Git Bash (MSysGit) that allowed you to specify JRUBY_HOME outside the script so you wouldn't have to worry about c:\whatever vs. /c/whatever rewriting issues. This looks like it might resolve the situation in a more general way. Do you think so?

jstoneham commented Jun 8, 2011

I was about to create a pull request that made things work under Git Bash (MSysGit) that allowed you to specify JRUBY_HOME outside the script so you wouldn't have to worry about c:\whatever vs. /c/whatever rewriting issues. This looks like it might resolve the situation in a more general way. Do you think so?

@jasonkarns

This comment has been minimized.

Show comment
Hide comment
@jasonkarns

jasonkarns Jun 8, 2011

Contributor

I can't be sure, but I don't think that will solve the issue. MinGW is already looking in the correct location, it's just using the wrong executable. The problem is that MinGW sees the jruby shell script and tries to execute that first, which doesn't work from MinGW. On Windows, jruby.exe is what ought to be executed. The simplest solution is to simply delete the jruby shell script. My change accomplishes virtually the same thing, by quickly executing jruby.exe from the jruby shell script.

Contributor

jasonkarns commented Jun 8, 2011

I can't be sure, but I don't think that will solve the issue. MinGW is already looking in the correct location, it's just using the wrong executable. The problem is that MinGW sees the jruby shell script and tries to execute that first, which doesn't work from MinGW. On Windows, jruby.exe is what ought to be executed. The simplest solution is to simply delete the jruby shell script. My change accomplishes virtually the same thing, by quickly executing jruby.exe from the jruby shell script.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jun 25, 2011

Member

This seems OK to pull, but for some reason Github won't let me. ("This pull request can not be automatically merged.")

Can you open a ticket at http://bugs.jruby.org and attach a git patch there?

Member

BanzaiMan commented Jun 25, 2011

This seems OK to pull, but for some reason Github won't let me. ("This pull request can not be automatically merged.")

Can you open a ticket at http://bugs.jruby.org and attach a git patch there?

@jasonkarns

This comment has been minimized.

Show comment
Hide comment
@jasonkarns

jasonkarns Jun 26, 2011

Contributor

I created a new branch (mingw) and rebased from master in order to make a clean merge. New pull request from mingw branch here: #42

Contributor

jasonkarns commented Jun 26, 2011

I created a new branch (mingw) and rebased from master in order to make a clean merge. New pull request from mingw branch here: #42

@jasonkarns

This comment has been minimized.

Show comment
Hide comment
@jasonkarns

jasonkarns Jun 27, 2011

Contributor

This pull request was duplicated by pull #42 which was successfully merged into master and closed.

Contributor

jasonkarns commented Jun 27, 2011

This pull request was duplicated by pull #42 which was successfully merged into master and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment