New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread-context refactor backtrace retrieval #3722

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kares
Member

kares commented Mar 10, 2016

historically there's createBacktrace2(int level, boolean nativeException)
... whose parameters are no longer used, proposing a getBacktrace() instead

getter name chosen since thread-context manages a backtrace state - does not need to create/generate one.

alternatively getBacktrace(int level) is added although we do not use the API.

kares added some commits Feb 23, 2016

deprecate ThreadContext's createBacktrace2 in favor of getBacktrace
... not really "creating" the backtrace - simply returning raw tracked backtrace elements

@kares kares added this to the JRuby 9.1.0.0 milestone Mar 10, 2016

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Mar 10, 2016

Member

Are the "final" variable changes something your editor/IDE is doing? I don't mind it for new code but making changes like that in otherwise-unmodified code really messes up the diff.

Otherwise, this seems like a fine change and you should go ahead with it.

Member

headius commented Mar 10, 2016

Are the "final" variable changes something your editor/IDE is doing? I don't mind it for new code but making changes like that in otherwise-unmodified code really messes up the diff.

Otherwise, this seems like a fine change and you should go ahead with it.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 10, 2016

Member

@headius yep, thanks - will try to tidy up the commit to avoid unrelated changes.

Member

kares commented Mar 10, 2016

@headius yep, thanks - will try to tidy up the commit to avoid unrelated changes.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Mar 10, 2016

Member

cleaned up: f060c79 and pushed to master

Member

kares commented Mar 10, 2016

cleaned up: f060c79 and pushed to master

@kares kares closed this Mar 10, 2016

@kares kares deleted the test-backtrace-refactor branch Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment