/ jruby Public
cleanup NativeException #3773
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
wasn't able to find a test/spec or a reason why
9.1 sounds like a good place to break away from that message building - which would actually only be seen very rarely (effectively almost never without hacks) even without the patch as
RaiseExceptiondoes re-set the
providedMessagefield in case of the
another annoyance with
cause.stackTrace + backtracejoin-ing - which shouldn't be necessary at all ... for now I've kept it for cases where the trace heads do not point to the same location. that means 99% cases it won't show up. except when the head would be filtered away as a JRuby internal. there seem to have been some special
NativeExceptionfiltering in place previously but with filtering going on elsewhere I did not want to filter twice esp as it seemed unnecessary.
tests on Java as well as Ruby side to cover functionality.
getMessageAsJavaString(would love to have been able to just change
String:) which is used by
RaiseException- this way at least for
NativeExceptionthe String -> RubyString -> String message conversion can be avoided