New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ji] allow for initialize() to be a valid Java method #3807
Conversation
…d all way back to 1.7) fixes #1408
4ba6c3b
to
00ef1b8
Compare
@kares This one makes me nervous() IRubyObject.initialize() just feels like something I could see a native ext calling. OTOH it has been throwing Deprecated errors for 2+ years. |
@enebo yeah I wasn't sure about this one either. feel free to postpone (or just remove milestone). |
@kares I feel too leery on this one but I don't want it open until our next major reelase. So I am closing. |
re-opening ... potentially to be considered for next major release |
Any hope for this one? I just bumped into this exact same issue |
After looking at this again...I'm not really too scared of removing this long-deprecated method. @enebo Worst case we'd have to restore it in 9.2.1, right? |
@headius this is a significant release so I tend to agree with you. As you say worst-case revert if we get too many troubles :) |
(been deprecated all way back to 1.7) ... so maybe a good time to remove?!
and resolve #1408