Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[ji] allow for initialize() to be a valid Java method #3807
Conversation
kares
added
the
java integration
label
Apr 18, 2016
kares
added this to the JRuby 9.1.0.0 milestone
Apr 18, 2016
This comment has been minimized.
This comment has been minimized.
|
@kares This one makes me nervous() IRubyObject.initialize() just feels like something I could see a native ext calling. OTOH it has been throwing Deprecated errors for 2+ years. |
This comment has been minimized.
This comment has been minimized.
|
@enebo yeah I wasn't sure about this one either. feel free to postpone (or just remove milestone). |
This comment has been minimized.
This comment has been minimized.
|
@kares I feel too leery on this one but I don't want it open until our next major reelase. So I am closing. |
enebo
closed this
Apr 20, 2016
kares
removed this from the JRuby 9.1.0.0 milestone
Apr 20, 2016
enebo
modified the milestone:
Non-Release
May 25, 2016
kares
modified the milestones:
JRuby 9.2.0.0,
Non-Release
Jun 2, 2016
kares
reopened this
Jun 2, 2016
This comment has been minimized.
This comment has been minimized.
|
re-opening ... potentially to be considered for next major release |
kares
referenced this pull request
Aug 15, 2016
Open
java_signature not honored at runtime become_java! #3366
kares
referenced this pull request
Feb 18, 2017
Closed
Jruby class implementing java interface with "initialize" method as a part of the interface fails to compile with jrubyc #1408
This comment has been minimized.
This comment has been minimized.
|
Any hope for this one? I just bumped into this exact same issue |
This comment has been minimized.
This comment has been minimized.
|
After looking at this again...I'm not really too scared of removing this long-deprecated method. @enebo Worst case we'd have to restore it in 9.2.1, right? |
This comment has been minimized.
This comment has been minimized.
|
@headius this is a significant release so I tend to agree with you. As you say worst-case revert if we get too many troubles :) |
kares commentedApr 18, 2016
(been deprecated all way back to 1.7) ... so maybe a good time to remove?!
and resolve #1408