New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ji] allow for initialize() to be a valid Java method #3807

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
4 participants
@kares
Member

kares commented Apr 18, 2016

(been deprecated all way back to 1.7) ... so maybe a good time to remove?!

and resolve #1408

@kares kares added this to the JRuby 9.1.0.0 milestone Apr 18, 2016

@enebo

This comment has been minimized.

Member

enebo commented Apr 20, 2016

@kares This one makes me nervous() IRubyObject.initialize() just feels like something I could see a native ext calling. OTOH it has been throwing Deprecated errors for 2+ years.

@kares

This comment has been minimized.

Member

kares commented Apr 20, 2016

@enebo yeah I wasn't sure about this one either. feel free to postpone (or just remove milestone).

@enebo

This comment has been minimized.

Member

enebo commented Apr 20, 2016

@kares I feel too leery on this one but I don't want it open until our next major reelase. So I am closing.

@enebo enebo closed this Apr 20, 2016

@kares kares removed this from the JRuby 9.1.0.0 milestone Apr 20, 2016

@enebo enebo modified the milestone: Non-Release May 25, 2016

@kares kares modified the milestones: JRuby 9.2.0.0, Non-Release Jun 2, 2016

@kares kares reopened this Jun 2, 2016

@kares

This comment has been minimized.

Member

kares commented Jun 2, 2016

re-opening ... potentially to be considered for next major release

@ivoanjo

This comment has been minimized.

Contributor

ivoanjo commented Apr 30, 2018

Any hope for this one? I just bumped into this exact same issue 😱

@headius

This comment has been minimized.

Member

headius commented May 16, 2018

After looking at this again...I'm not really too scared of removing this long-deprecated method.

@enebo Worst case we'd have to restore it in 9.2.1, right?

@enebo

This comment has been minimized.

Member

enebo commented May 16, 2018

@headius this is a significant release so I tend to agree with you. As you say worst-case revert if we get too many troubles :)

@headius headius merged commit 6a1ee91 into master May 16, 2018

1 of 3 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the jrubyc-initialize branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment