New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixnum#bit_length - uses bit inversion when the value is negative #3833

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
2 participants
@lucasallan
Member

lucasallan commented Apr 27, 2016

Making sure the behaviour matches MRI https://github.com/ruby/ruby/blob/trunk/numeric.c#L4280

Thanks @jkr2255

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Apr 28, 2016

Member

Nice!

Member

headius commented Apr 28, 2016

Nice!

@headius headius merged commit 85212ad into jruby:master Apr 28, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Apr 28, 2016

Member

If you haven't already, can you add a ruby/spec for this?

Member

headius commented Apr 28, 2016

If you haven't already, can you add a ruby/spec for this?

@headius headius added this to the JRuby 9.1.0.0 milestone Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment