New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit padding width for strftime. #3872

Merged
merged 1 commit into from May 11, 2016

Conversation

Projects
None yet
1 participant
@headius
Member

headius commented May 11, 2016

See https://bugs.ruby-lang.org/issues/4456. I'm not certain MRI
has a hard limit in place, but that's the approach I went with.

The original test that started failing (usually timing out) is
from MRI's TestTimeExtension#test_huge_precision:

  def test_huge_precision
    bug4456 = '[ruby-dev:43284]'
    assert_normal_exit %q{ Time.now.strftime("%1000000000F") }, bug4456
  end

We attempted to honor that giant padding width blindly, usually
running out of memory or timing out while the GC thrashed.

Limit padding width for strftime.
See https://bugs.ruby-lang.org/issues/4456. I'm not certain MRI
has a hard limit in place, but that's the approach I went with.

The original test that started failing (usually timing out) is
from MRI's TestTimeExtension#test_huge_precision:

```
  def test_huge_precision
    bug4456 = '[ruby-dev:43284]'
    assert_normal_exit %q{ Time.now.strftime("%1000000000F") }, bug4456
  end
```

We attempted to honor that giant padding width blindly, usually
running out of memory or timing out while the GC thrashed.

@headius headius added this to the JRuby 9.1.1.0 milestone May 11, 2016

@headius headius self-assigned this May 11, 2016

@headius headius merged commit 0e45b9b into master May 11, 2016

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@headius headius deleted the test-strftime-pad-limit branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment