/ jruby Public
Collect all DNS sections by calling to each_resource instead of each_answer #3886
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Disclaimer: same pull request on mruby impl (ruby/ruby#797), and bug open (https://bugs.ruby-lang.org/issues/12372). Not sure if I should report here a bug for the stdlib. For completeness:
A call to
Message#each_answerdoes only include answers, however there are also two more kinds of
responses: Authority and Additional. Iterating through
Message#each_resourceallows us to retrieve
all information from the
This is specially important if, for example, we are trying to retrieve nameservers for a certain domain.
nilis returned. This, in a terminal fashion is equivalent to:
There is indeed a response, but in the authority section, that is right now not collected by