Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable the AddLocalVarLoadStore pass to fix #3891. #3898
This was a good experiment, but we're not properly ensuring the
It may be possible to improve the pass so that it localizes the
This is now working well, and the fixes here should probably not be squashed because there's other bits and pieces with important history.
I did discover #3906 and related minor issues in the process of getting this passing tests. With #3906 outstanding, there's a chance this PR might cause OptimizeDelegation to never work in the presence of keyword arguments, since we do not keep everything in JVM locals anymore.