New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften this restriction to just readable resources. #3902

Merged
merged 1 commit into from May 26, 2016

Conversation

Projects
None yet
3 participants
@headius
Member

headius commented May 18, 2016

Additional fix for issue exposed by #3901. Devices, like ttys,
pipes, fifos and the like may be neither file nor symlink, but
still readable as script source. The restriction here is
unnecessary.

Ping @mkristian... I softened this test but I'm not sure why it was so restrictive in the first place. Is this change ok?

Soften this restriction to just readable resources.
Additional fix for issue exposed by #3901. Devices, like ttys,
pipes, fifos and the like may be neither file nor symlink, but
still readable as script source. The restriction here is
unnecessary.

@headius headius merged commit d92362e into jruby:jruby-1_7 May 26, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@headius headius added this to the JRuby 9.1.3.0 milestone May 26, 2016

@headius headius deleted the headius:soften_script_test branch May 26, 2016

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian May 26, 2016

Member

@headius looks ok to me. do not remember the details, but was something like a directory path as resource.

Member

mkristian commented May 26, 2016

@headius looks ok to me. do not remember the details, but was something like a directory path as resource.

@jellymann

This comment has been minimized.

Show comment
Hide comment
@jellymann

jellymann Aug 22, 2016

Contributor

@headius @mkristian I have tested with a directory, it passes canRead and then throws at inputStream. See #4100

Contributor

jellymann commented Aug 22, 2016

@headius @mkristian I have tested with a directory, it passes canRead and then throws at inputStream. See #4100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment