Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows symlink #3926

Merged
merged 1 commit into from May 25, 2016
Merged

Windows symlink #3926

merged 1 commit into from May 25, 2016

Conversation

@headius
Copy link
Member

@headius headius commented May 25, 2016

This incorporates symlink support from @djberg96's win32-file and ffi-win32-extensions projects.

@djberg96 Ideally we'd just include this in JRuby under our tri-license (EPL, GPL2, LGPL2). If that's ok with you, let us know you consent to your code being licensed that way.

This seems to be everything I need, but when I try to install warbler (this is intended to fix #3905) I get this peculiar error:

λ gem install warbler
ERROR:  While executing gem ... (SystemCallError)
    Unknown error 1314 - CreateSymbolicLink

So this isn't quite ready yet.

@headius
Copy link
Member Author

@headius headius commented May 25, 2016

Ahh, seems like this may be a permission issue on Windows 7: http://stackoverflow.com/questions/26020777/createsymboliclink-runs-on-windows-8-returns-error-code-1314-on-windows-7

Maybe it's time for me to update my Windows to 10, but I think you want this to work on Windows 7 too, right @djberg96?

@djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 25, 2016

@headius Yeah, we don't try to elevate privileges, users would have to install with administrator rights.

I'm not sure if we want to do that, but you certainly could. And you definitely have permission to copy/paste whatever you need.

I still don't understand this rake version error, though.

@headius
Copy link
Member Author

@headius headius commented May 25, 2016

Yeah I'm not sure about that error either. I'll see if I can reproduce it.

@headius headius force-pushed the headius:windows_symlink branch from 9f75a9a to 48bcc37 May 25, 2016
headius added a commit to headius/jruby that referenced this pull request May 25, 2016
@headius
Copy link
Member Author

@headius headius commented May 25, 2016

Will merge after we have a clean travis run.

Permission given to relicense in JRuby by @djberg96 at
#3926 (comment)
@headius headius force-pushed the headius:windows_symlink branch from 48bcc37 to 3d1ada0 May 25, 2016
@headius
Copy link
Member Author

@headius headius commented May 25, 2016

Rebase to master will be clean, so I'm merging now.

@headius headius merged commit 07313c1 into jruby:master May 25, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@headius headius deleted the headius:windows_symlink branch May 25, 2016
enebo added a commit that referenced this pull request May 26, 2016
Permission given to relicense in JRuby by @djberg96 at
#3926 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.