New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport BigDecimal .to_r for #3728 #3927

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
2 participants
@ahorek
Contributor

ahorek commented May 25, 2016

Pavel Rosický

@headius headius added this to the JRuby 1.7.26 milestone May 25, 2016

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 25, 2016

Member

You using 1.7 eh? Seems fine to backport this if it's needed. We'll let CI run and then merge it.

Member

headius commented May 25, 2016

You using 1.7 eh? Seems fine to backport this if it's needed. We'll let CI run and then merge it.

@ahorek

This comment has been minimized.

Show comment
Hide comment
@ahorek

ahorek May 25, 2016

Contributor

I think that this change is isolated and can be safely backported (if 1.7 is still maintained). But it's not a real issue for me, I'm using 9k :)

Contributor

ahorek commented May 25, 2016

I think that this change is isolated and can be safely backported (if 1.7 is still maintained). But it's not a real issue for me, I'm using 9k :)

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 25, 2016

Member

Not sure why two of the builds failed so I restarted them to see.

Member

headius commented May 25, 2016

Not sure why two of the builds failed so I restarted them to see.

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius May 26, 2016

Member

I'm going to try to kick that test-extended job one more time. I see a "Killed" in the log which usually means a JVM process crashed somewhere.

Member

headius commented May 26, 2016

I'm going to try to kick that test-extended job one more time. I see a "Killed" in the log which usually means a JVM process crashed somewhere.

@headius headius merged commit 2005fa7 into jruby:jruby-1_7 Aug 23, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment