Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some parts of Socket::Option #4038

Merged
merged 5 commits into from Aug 11, 2016
Merged

Fix some parts of Socket::Option #4038

merged 5 commits into from Aug 11, 2016

Conversation

@etehtsea
Copy link
Contributor

etehtsea commented Jul 29, 2016

Specs passed, so, hopefully, it should work.

P.S. Also I wanted to fix Socket.linger, but it requires more substantial changes and I put it aside for a while.

Disclaimer:
1 sntxfelfuqlsfdnvzkj6ia

I will be happy to see some feedback how it could be improved.

ProtocolFamily family = SocketUtils.protocolFamilyFromArg(args[0]);
SocketLevel level = RubyBasicSocket.levelFromArg(args[1]);
SocketOption option = RubyBasicSocket.optionFromArg(args[2]);
int intData = args[3].isTrue() ? 1 : 0;

This comment has been minimized.

Copy link
@etehtsea

etehtsea Jul 29, 2016

Author Contributor

Should it be checked there that it actually a boolean arg and what to do in case if it's not?

@etehtsea etehtsea force-pushed the etehtsea:socket-options branch from 758e9e0 to c953ae9 Jul 29, 2016
etehtsea added 5 commits Jul 28, 2016
- Fix Socket::Option.int
- Fix Socket::Option.bool
- Fix Socket::Option#bool
Fix socket initialization with type passed as a string (for ex.
'SOCK_STREAM')
@etehtsea etehtsea force-pushed the etehtsea:socket-options branch from c953ae9 to 6f143cd Aug 11, 2016
@enebo enebo added this to the JRuby 9.1.3.0 milestone Aug 11, 2016
@enebo enebo added the core label Aug 11, 2016
@enebo enebo merged commit 1482ff8 into jruby:master Aug 11, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@etehtsea etehtsea deleted the etehtsea:socket-options branch Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.