/ jruby Public
Fix Socket.tcp connect_timeout option #4061
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Socket.tcp(host, port, connect_timeout: 0.1)
ignored timeout option. This happened because
mistakenly responded with
After fixing it this code started to constantly fail with timeout error.
IO#wait_writablefixed this issue.
Added adopted spec from MRI, because it's excluded by other reasons.