Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Write a log message when findClass IOException is caught #4062
This commit just adds a simple
@kares I've only seen this exception pop up when something bad happens when the jar file is being consumed, like the process is out of file descriptors. I expect that for many apps (like ours) that this exception may end up being fatal - since a needed class won't be found later on. So I wouldn't expect it too appear too frequently for one application run in the log output.
We found having the full exception stack trace in the log to be pretty helpful in determining where the call to
Do you see a downside to including the whole exception in the log - especially considering that it's only at debug level and debug isn't enabled by default? If we're okay with including the full exception, would you prefer that I take the
Thanks much for reviewing this!
I think it would be pretty rare for this exception and message to be written to the log. The only time I've seen it logged is for the case where the process runs out of file descriptors, which seems like it would be relatively rare. This is the exact case where having the extra detail would be really helpful.
@kares - are you okay with merging this PR as-is, then? Thanks again!