Explicitly close input stream in CompoundJarURLStreamHandler #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the stream which is opened for a `URL` within `CompoundJarURLStreamHandler` is explicitly closed before it falls out of scope. Previously, the stream would still eventually be closed but only after Garbage Collection.
|
@kares should this get merged to master? |
|
@enebo It didn't look to me like the |
|
@camlow325 you are correct! It is not there. I was just double checking since I saw a PR merged to 1.7. Better to ask than forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This commit ensures that the stream which is opened for a
URLwithinCompoundJarURLStreamHandleris explicitly closed before it falls outof scope. Previously, the stream would still eventually be closed but
only after Garbage Collection.