workaround compilation problems with unsafe-mock.jar #4107
Conversation
|
Gross. That this actually works is even grosser :-) I'll run some sanity checks here. |
|
Oracle Java 7 and 8 both seem fine with the change. I'm checking J9 now. |
|
As I feared, this patch does not appear to work on J9. I'll try to get the exact error. |
|
Here's my daily rant about Maven refusing to show the actual error when compilation fails.
Now that that's over... I captured the javac command line, and it worked just fine in J9 at the command line. So perhaps J9 issue was something else? I'D SURE LIKE TO SEE WHAT THE ERROR WAS, MAVEN. |
|
Well I'm stumped. I can't get Maven to tell me why J9 javac is failing, and it works ok at the command line. I suppose we can go with this, since the bare -X flag does appear to work on J9 Java 8 javac. |
|
we can also enforce a particular jdk to build, like jdk version bigger then 8, or make the switches depending on the jdk version via profiles for those versions. |
|
Ok, I've confirmed that J9 Java 8 on Ubuntu can't build JRuby either way, so we'll just merge this. |
|
Awesome! so once a new release of jruby comes out that includes this change, we'll be able to build using that latest version of the openjdk-7-jdk ubuntu package. |
- For JRuby 9.1.2.0 and below, building JRuby using maven and ubuntu openjdk-7-jdk 7u111-2.6.7-0ubuntu0.14.04.3 is broken. It was fixed in JRuby by jruby/jruby#4107 - This fix is scheduled for JRuby 9.1.3.0, when this is released, we can re-enable the spec at lock it to 9.1.3.0 [#128679225] Signed-off-by: James Wen <jrw2175@columbia.edu>
- For JRuby 9.1.2.0 and below, building JRuby using maven and ubuntu openjdk-7-jdk 7u111-2.6.7-0ubuntu0.14.04.3 is broken. It was fixed in JRuby by jruby/jruby#4107 - This fix is scheduled for JRuby 9.1.3.0, when this is released, we can re-enable the spec at lock it to 9.1.3.0 [#128679225] Signed-off-by: James Wen <jrw2175@columbia.edu>
fixes #4103