Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround compilation problems with unsafe-mock.jar #4107

Merged
merged 1 commit into from Aug 24, 2016
Merged

workaround compilation problems with unsafe-mock.jar #4107

merged 1 commit into from Aug 24, 2016

Conversation

@mkristian
Copy link
Member

@mkristian mkristian commented Aug 24, 2016

fixes #4103

@kares kares added this to the JRuby 9.1.3.0 milestone Aug 24, 2016
@headius
Copy link
Member

@headius headius commented Aug 24, 2016

Gross. That this actually works is even grosser :-)

I'll run some sanity checks here.

@headius
Copy link
Member

@headius headius commented Aug 24, 2016

Oracle Java 7 and 8 both seem fine with the change. I'm checking J9 now.

@headius
Copy link
Member

@headius headius commented Aug 24, 2016

As I feared, this patch does not appear to work on J9. I'll try to get the exact error.

@headius
Copy link
Member

@headius headius commented Aug 24, 2016

Here's my daily rant about Maven refusing to show the actual error when compilation fails.

(╯°□°)╯︵ ┻━┻

Now that that's over...

I captured the javac command line, and it worked just fine in J9 at the command line. So perhaps J9 issue was something else? I'D SURE LIKE TO SEE WHAT THE ERROR WAS, MAVEN.

@headius
Copy link
Member

@headius headius commented Aug 24, 2016

Well I'm stumped. I can't get Maven to tell me why J9 javac is failing, and it works ok at the command line. I suppose we can go with this, since the bare -X flag does appear to work on J9 Java 8 javac.

@mkristian
Copy link
Member Author

@mkristian mkristian commented Aug 24, 2016

we can also enforce a particular jdk to build, like jdk version bigger then 8, or make the switches depending on the jdk version via profiles for those versions.

@headius
Copy link
Member

@headius headius commented Aug 24, 2016

Ok, I've confirmed that J9 Java 8 on Ubuntu can't build JRuby either way, so we'll just merge this.

@headius headius merged commit 72ac6a8 into master Aug 24, 2016
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RochesterinNYC
Copy link

@RochesterinNYC RochesterinNYC commented Aug 24, 2016

Awesome! so once a new release of jruby comes out that includes this change, we'll be able to build using that latest version of the openjdk-7-jdk ubuntu package.

RochesterinNYC added a commit to cloudfoundry/binary-builder that referenced this pull request Aug 25, 2016
- For JRuby 9.1.2.0 and below, building JRuby using maven and ubuntu
  openjdk-7-jdk 7u111-2.6.7-0ubuntu0.14.04.3 is broken. It was fixed in
  JRuby by jruby/jruby#4107
- This fix is scheduled for JRuby 9.1.3.0, when this is released, we
  can re-enable the spec at lock it to 9.1.3.0

[#128679225]

Signed-off-by: James Wen <jrw2175@columbia.edu>
bonfilsd added a commit to orange-cloudfoundry/binary-builder that referenced this pull request Oct 12, 2017
- For JRuby 9.1.2.0 and below, building JRuby using maven and ubuntu
  openjdk-7-jdk 7u111-2.6.7-0ubuntu0.14.04.3 is broken. It was fixed in
  JRuby by jruby/jruby#4107
- This fix is scheduled for JRuby 9.1.3.0, when this is released, we
  can re-enable the spec at lock it to 9.1.3.0

[#128679225]

Signed-off-by: James Wen <jrw2175@columbia.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.