New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Socket::Option support #4119

Merged
merged 7 commits into from Sep 12, 2016

Conversation

Projects
None yet
2 participants
@etehtsea
Contributor

etehtsea commented Aug 27, 2016

This PR includes:

  • full (I hope) Socket::Option support;
  • passing Socket::Option as setsockopt argument;
  • fix for the #4040;
  • properly handles socket prefixed options/levels (SOL_LEVEL, SO_OPTION) (fix for the #3438);
  • properly handles unsupported socket constants;
@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea Sep 8, 2016

Contributor

@headius: I need this to be merged somewhere to move on. I can retarget it to another branch if needed.

Contributor

etehtsea commented Sep 8, 2016

@headius: I need this to be merged somewhere to move on. I can retarget it to another branch if needed.

@etehtsea etehtsea changed the title from Getset option linger to Full Socket::Option support Sep 8, 2016

etehtsea and others added some commits Aug 15, 2016

Fix passing socket option in a form of SO_OPTION
For example:
Socket::Option.new(:UNSPEC, :SOCKET, :SO_LINGER, [0, 0].pack('i*')
Fixes #3438
More robust conversion and value-checking.
Covers address family, protocol family, socket type, and protocol.
Fix passing socket level in a form of SOL_LEVEL
For example:
Socket::Option.int(:AF_UNSPEC, :SOL_SOCKET, :LINGER, 1)
Fixes #3438
More robust conversion and value-checking
Also cover socket level and socket option

@headius headius added this to the JRuby 9.1.6.0 milestone Sep 12, 2016

@headius headius merged commit bbceb69 into jruby:master Sep 12, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@etehtsea etehtsea deleted the etehtsea:getset-option-linger branch Sep 12, 2016

@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea Sep 12, 2016

Contributor

🎉🎉🎉

Contributor

etehtsea commented Sep 12, 2016

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment