Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Socket::Option support #4119

Merged
merged 7 commits into from Sep 12, 2016
Merged

Full Socket::Option support #4119

merged 7 commits into from Sep 12, 2016

Conversation

@etehtsea
Copy link
Contributor

etehtsea commented Aug 27, 2016

This PR includes:

  • full (I hope) Socket::Option support;
  • passing Socket::Option as setsockopt argument;
  • fix for the #4040;
  • properly handles socket prefixed options/levels (SOL_LEVEL, SO_OPTION) (fix for the #3438);
  • properly handles unsupported socket constants;
@etehtsea etehtsea force-pushed the etehtsea:getset-option-linger branch 3 times, most recently from da90e88 to 5091cef Aug 28, 2016
@etehtsea etehtsea force-pushed the etehtsea:getset-option-linger branch from 5091cef to 8cc3ddb Sep 7, 2016
@etehtsea
Copy link
Contributor Author

etehtsea commented Sep 8, 2016

@headius: I need this to be merged somewhere to move on. I can retarget it to another branch if needed.

@etehtsea etehtsea changed the title Getset option linger Full Socket::Option support Sep 8, 2016
etehtsea and others added 7 commits Aug 15, 2016
For example:
Socket::Option.new(:UNSPEC, :SOCKET, :SO_LINGER, [0, 0].pack('i*')
Fixes #3438
Covers address family, protocol family, socket type, and protocol.
For example:
Socket::Option.int(:AF_UNSPEC, :SOL_SOCKET, :LINGER, 1)
Fixes #3438
Also cover socket level and socket option
Fixes #4040
@etehtsea etehtsea force-pushed the etehtsea:getset-option-linger branch from 8cc3ddb to 1902354 Sep 8, 2016
@headius headius added this to the JRuby 9.1.6.0 milestone Sep 12, 2016
@headius headius merged commit bbceb69 into jruby:master Sep 12, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@etehtsea etehtsea deleted the etehtsea:getset-option-linger branch Sep 12, 2016
@etehtsea
Copy link
Contributor Author

etehtsea commented Sep 12, 2016

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.