Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate framed invoke #4139

merged 4 commits into from Sep 6, 2016


Copy link

@headius headius commented Sep 6, 2016

This deprecates the "invoke" forms in Helpers and RubyClass that depended on having a Ruby frame pushed to get "self" for visibility checking. Improper use of this method (in this case, frame was eliminated) caused #4134.

This PR is expected to be applied after #4138, which fixes #4134 by changing attribute assigns to use a CallSite like any other invocation.

headius added 4 commits Sep 6, 2016
This has worked for the JIT and it runs almost all the same
tests as the interpreter.

See jruby#4134.
This is in response to callers not seting up frame and breaking
visibility checks in jruby#4134. This goes along with jruby#4138.
@headius headius added this to the JRuby milestone Sep 6, 2016
Copy link
Member Author

headius commented Sep 6, 2016

Note that only one of the commits in this PR is actually from this PR...the other three are from #4138.

@headius headius merged commit 82b771a into jruby:master Sep 6, 2016
@headius headius deleted the deprecate_framed_invoke branch Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Rails new fails with and "--dev" option
1 participant