New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4147 #4153

Merged
merged 1 commit into from Sep 14, 2016

Conversation

Projects
None yet
3 participants
@smk0621
Contributor

smk0621 commented Sep 14, 2016

When check the OS platform, the RUBY_PLATFORM return 'java' in JRuby.
It is better to use RbConfig::CONFIG['host_os'] .

fixes #4147

Fix JRuby issue#4147
When check the OS platform, the RUBY_PLATFORM return 'java' in JRuby.

@kares kares added this to the JRuby 9.1.6.0 milestone Sep 14, 2016

@kares kares merged commit 6ce5e55 into jruby:master Sep 14, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Sep 14, 2016

Member

@headius can you commit this upstream? I don't know if they want rbconfig but this is a better check

Member

enebo commented Sep 14, 2016

@headius can you commit this upstream? I don't know if they want rbconfig but this is a better check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment