New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring BigMath::log behaviour closer to MRI #4170

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@shirshendu
Contributor

shirshendu commented Sep 22, 2016

Especially for a Rational, high precision use-case

Fixes #4158

Bring BigMath::log behaviour closer to MRI
Especially for a Rational, high precision use-case

Fixes #4158
@shirshendu

This comment has been minimized.

Show comment
Hide comment
@shirshendu

shirshendu Sep 22, 2016

Contributor

Just for convenience, the command for running the newly added test case:
bin/jruby test/mri/bigdecimal/test_bigdecimal.rb -n test_BigMath_log_with_rational_high_precision_case

Contributor

shirshendu commented Sep 22, 2016

Just for convenience, the command for running the newly added test case:
bin/jruby test/mri/bigdecimal/test_bigdecimal.rb -n test_BigMath_log_with_rational_high_precision_case

r = Rational(1_234_567_890, 987_654_321)
assert_in_delta(result, BigMath.log(r, 50), 0.0000000000_0000000000_0000000000_0000000000_0000000001)
end

This comment has been minimized.

@headius

headius Sep 22, 2016

Member

We don't usually edit the MRI tests since there's no good process for upstreaming those changes. I'll move this to spec/ruby.

@headius

headius Sep 22, 2016

Member

We don't usually edit the MRI tests since there's no good process for upstreaming those changes. I'll move this to spec/ruby.

headius added a commit that referenced this pull request Sep 22, 2016

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Sep 22, 2016

Member

Merged your fix in 68552a3 and the spec/ruby change in 84a5f78. Thanks!

Member

headius commented Sep 22, 2016

Merged your fix in 68552a3 and the spec/ruby change in 84a5f78. Thanks!

@headius headius closed this Sep 22, 2016

@headius headius added this to the JRuby 9.1.6.0 milestone Sep 22, 2016

eregon added a commit to ruby/spec that referenced this pull request Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment