Bring BigMath::log behaviour closer to MRI #4170

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@shirshendu
Contributor

Especially for a Rational, high precision use-case

Fixes #4158

@shirshendu shirshendu Bring BigMath::log behaviour closer to MRI
Especially for a Rational, high precision use-case

Fixes #4158
129ae0c
@shirshendu
Contributor

Just for convenience, the command for running the newly added test case:
bin/jruby test/mri/bigdecimal/test_bigdecimal.rb -n test_BigMath_log_with_rational_high_precision_case

+ r = Rational(1_234_567_890, 987_654_321)
+ assert_in_delta(result, BigMath.log(r, 50), 0.0000000000_0000000000_0000000000_0000000000_0000000001)
+ end
+
@headius
headius Sep 22, 2016 Member

We don't usually edit the MRI tests since there's no good process for upstreaming those changes. I'll move this to spec/ruby.

@headius
Member
headius commented Sep 22, 2016

Merged your fix in 68552a3 and the spec/ruby change in 84a5f78. Thanks!

@headius headius closed this Sep 22, 2016
@headius headius added this to the JRuby 9.1.6.0 milestone Sep 22, 2016
@eregon eregon added a commit to ruby/spec that referenced this pull request Sep 27, 2016
@headius @eregon headius + eregon Spec for high-precision BigMath.log on a Rational. 2fdf80d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment