/ jruby Public
Fix issues with File.dirname #4177
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This fixes #4116
e.g. The result of
File.dirname('/foo/bar\baz')on Windows is
while on Unix it is
"bar\baz"is a single file name (
\is not a path separator in Unix)
As an added bonus, this also fixes a number of inconsistencies with MRI with regard to Windows UNC paths, notably:
A typical UNC path is made up of
"//<host>/<share>/path/to/file.ext", where the "root" is
This means that, while
"//foo/bar"is the "root").
Extraneous "leading" separators are removed, e.g.
This logic must not be confused with Unix paths, where there should be no more than 1 separator at the beginning of the string.
File.dirname('/foo/bar')should still be
"/foo", on both Unix and Windows.
For all of the above,
\are completely interchangeable at all times on Windows.
Windows UNC paths are not recognised at all on Unix, e.g.