Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generify accept methods in AST #4197

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
4 participants
@jsyeo
Copy link
Contributor

jsyeo commented Oct 1, 2016

Some of the AST's accept methods were returning Object instead of the generic type.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Oct 12, 2016

@jsyeo If I have compiled with the previous visitor API will this still run with this generic version once compiled? Since JVM does type erasure I think it will but I am not positive. Do you know? I consider AST an internal API more or less for jruby proper but I still like to avoid compat errors if possible.

@headius

This comment has been minimized.

Copy link
Member

headius commented Oct 14, 2016

I believe it still looks identical (returning Object) if it claims to return T.

@jsyeo

This comment has been minimized.

Copy link
Contributor Author

jsyeo commented Oct 31, 2016

If I have compiled with the previous visitor API will this still run with this generic version once compiled?

Yes. I have tested it.

@enebo enebo added this to the JRuby 9.2.1.0 milestone Sep 19, 2018

@enebo enebo merged commit a611165 into jruby:master Sep 19, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.