New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Socket.socketpair to return Socket instances #4204

Merged
merged 5 commits into from Oct 5, 2016

Conversation

Projects
None yet
3 participants
@etehtsea
Contributor

etehtsea commented Oct 5, 2016

No description provided.

@headius

Functionality changes look fine, but @eregon needs to weigh in on the ruby/spec change.

s1, s2 = Socket.public_send(@method, :UNIX, :STREAM)
s1.should be_an_instance_of(Socket)
s2.should be_an_instance_of(Socket)

This comment has been minimized.

@eregon

eregon Oct 5, 2016

Member

The opened file descriptors should be closed here.

@eregon

eregon Oct 5, 2016

Member

The opened file descriptors should be closed here.

This comment has been minimized.

@etehtsea

etehtsea Oct 5, 2016

Contributor

done

@etehtsea

etehtsea Oct 5, 2016

Contributor

done

@etehtsea

This comment has been minimized.

Show comment
Hide comment
@etehtsea

etehtsea Oct 5, 2016

Contributor

Done.

Contributor

etehtsea commented Oct 5, 2016

Done.

@headius headius merged commit 4642234 into jruby:master Oct 5, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@headius headius added this to the JRuby 9.1.6.0 milestone Oct 5, 2016

@etehtsea etehtsea deleted the etehtsea:socket-socketpair branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment