New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush destination IO in IO.copy_stream #4207

Merged
merged 1 commit into from Oct 6, 2016

Conversation

Projects
None yet
2 participants
@grddev
Contributor

grddev commented Oct 6, 2016

Previously, any buffered IO was ignored when copying to the destination stream.

Untagged a couple of specs that are no longer failing with the additional flush.

Tested this against 9.1.5.0, 9.0.5.0, 1.7.26, and 1.7.19, and buffered IO was ignored in all instances.

Flush destination IO in IO.copy_stream
Previously, any buffered IO was ignored when copying to the destination stream.

Untagged a couple of specs that are no longer failing with the additional flush.
@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Oct 6, 2016

Member

Very nice, thanks!

Member

headius commented Oct 6, 2016

Very nice, thanks!

@headius headius merged commit 98918e4 into jruby:master Oct 6, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@headius headius added this to the JRuby 9.1.6.0 milestone Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment