Fix the incorrect opscode mapping in f2i() #4224

Merged
merged 1 commit into from Oct 12, 2016

Projects

None yet

3 participants

@himosqui
Contributor
  • f2i() should be mapped to F2I, instead of F2D. Note that F2I is a valid constant in org.objectweb.asm.Opcodes.
  • The incorrect mapping appears to be a copy-paste editing error from the above f2d() method.
  • Due to the error, when float-to-integer narrowing numeric conversion should occur, float-to-double widening numeric conversion was being done, which can have a negative impact on performance and memory usage.
@himosqui himosqui Fix the incorrect opscode mapping in f2i()
 - f2i() should be mapped to F2I, instead of F2D.
 - The incorrect opscode mapping appears to be a copy-paste editing error.
 - Due to the error, when float-to-integer narrowing numeric conversion should occur,
   float-to-double widening numeric conversion was being done, which can have a
   negative impact on performance or memory usage.
7e1c5e5
@kares
Member
kares commented Oct 12, 2016

najs ✂️ find!

@kares kares added this to the JRuby 9.1.6.0 milestone Oct 12, 2016
@enebo enebo merged commit 7c55b3b into jruby:master Oct 12, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment