New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect opscode mapping in f2i() #4224

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
3 participants
@sangmokh
Contributor

sangmokh commented Oct 12, 2016

  • f2i() should be mapped to F2I, instead of F2D. Note that F2I is a valid constant in org.objectweb.asm.Opcodes.
  • The incorrect mapping appears to be a copy-paste editing error from the above f2d() method.
  • Due to the error, when float-to-integer narrowing numeric conversion should occur, float-to-double widening numeric conversion was being done, which can have a negative impact on performance and memory usage.
Fix the incorrect opscode mapping in f2i()
 - f2i() should be mapped to F2I, instead of F2D.
 - The incorrect opscode mapping appears to be a copy-paste editing error.
 - Due to the error, when float-to-integer narrowing numeric conversion should occur,
   float-to-double widening numeric conversion was being done, which can have a
   negative impact on performance or memory usage.
@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Oct 12, 2016

Member

najs ✂️ find!

Member

kares commented Oct 12, 2016

najs ✂️ find!

@kares kares added this to the JRuby 9.1.6.0 milestone Oct 12, 2016

@enebo enebo merged commit 7c55b3b into jruby:master Oct 12, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment