Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add File.empty? #4296
This PR adds the class methods
See #4293 where feature is originally mentioned.
This PR gets the test
I did run into an issue while testing with just that file. If I ran just this command
I get an error about missing
I needed to add
This is my first time contributing to JRuby so let me know if there is something missing that I need to include.
@kcdragon Logic was right on. My only comment for next one is to try and use a full name like filename and not f. We have some other brace logic which is like 95% followed so that might be another style tweak suggestion in the future.
Congratulations you are the on JRuby commit board. The tracks have been greased...onward! :)
@kcdragon There are some examples of running individual test files from the MRI suite in BUILDING.md. Basically, the test/mri/runner.rb script can be used to set up appropriate paths and such, and there's a feature in there that's used to exclude tests known to fail (for maintaining a high-water mark).
Perhaps we should have a better page in the wiki for this.