Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix Array#sum and Enumerable#sum #4309
Conversation
phluid61
added some commits
Nov 16, 2016
This comment has been minimized.
This comment has been minimized.
|
I'm not entirely comfortable that RubyArray is now an expert on Fixnum, Bignum, Rational and Float, but the behaviour matches MRI's. |
This comment has been minimized.
This comment has been minimized.
|
Looks good! Thank you! |
headius
merged commit 46aca6c
into
jruby:ruby-2.4
Nov 17, 2016
headius
added this to the JRuby 9.2.0.0 milestone
Nov 17, 2016
headius
added
core
JRuby 9000
ruby 2.4
labels
Nov 17, 2016
phluid61
deleted the
phluid61:feature/optimise-enumerable-sum
branch
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
phluid61 commentedNov 17, 2016
This changes
Array#sumandEnumerable#sumto use Kahan's compensated summation algorithm, so we have the same rounding artifacts as MRI.It also includes some of the MRI's cascading coercion behaviour in
Array#sumNow all tests in
test/mri/ruby/test_array.rbandtest/mri/ruby/test_enum.rbpass, except for those depending on 'mathn' which I can't test because of an unrelated issue.Consider this a regression fix for #4297