New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marshaling Hash with default_proc set to nil #4321

Merged
merged 1 commit into from Nov 21, 2016

Conversation

Projects
None yet
2 participants
@kirs
Contributor

kirs commented Nov 20, 2016

When we set default_proc to nil, we also have to update the internal flag.

Fixes #4302

@enebo

Fix marshaling Hash with default_proc set to nil
When we set `default_proc` to nil, we also have to update the internal
flag.

Fixes
#4302

@enebo enebo merged commit 744a927 into jruby:master Nov 21, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@enebo enebo added this to the JRuby 9.1.7.0 milestone Nov 21, 2016

@enebo enebo added the core label Nov 21, 2016

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Nov 21, 2016

Member

@kirs Excellent. I was worried this involved more than nil so thanks for digging into this!

Member

enebo commented Nov 21, 2016

@kirs Excellent. I was worried this involved more than nil so thanks for digging into this!

kirs added a commit to kirs/jruby that referenced this pull request Nov 23, 2016

Skip less specs
With jruby#4321 merged, we no longer have
to skip that ruby spec.

@kirs kirs referenced this pull request Nov 23, 2016

Merged

Skip less specs #4331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment