Add optional digits for Float#floor #4337
Closed
Conversation
|
Can you resubmit this PR against the ruby-2.4 branch? I also think you can omit your tests because that branch has test_floor_with_precision. Looks good though! |
|
Since this is not Ruby 2.3 and we merged your other PR on 2.4 branch I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey!
I implemented the 1st part of this:
It's my first time working on JRuby code, so I hope this is ok :)