Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd optional digits for Float#floor #4337
Conversation
enebo
requested changes
Nov 28, 2016
Can you resubmit this PR against the ruby-2.4 branch? I also think you can omit your tests because that branch has test_floor_with_precision. Looks good though!
matugm
changed the base branch from
master
to
ruby-2.4
Nov 28, 2016
matugm
changed the base branch from
ruby-2.4
to
master
Nov 28, 2016
matugm
referenced this pull request
Nov 28, 2016
Merged
Add optional precision for Float#floor #4343
This comment has been minimized.
This comment has been minimized.
|
Since this is not Ruby 2.3 and we merged your other PR on 2.4 branch I am closing this one. |
enebo
closed this
Nov 29, 2016
headius
modified the milestone:
JRuby 9.2.0.0
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
matugm commentedNov 26, 2016
•
edited
Hey!
I implemented the 1st part of this:
It's my first time working on JRuby code, so I hope this is ok :)