Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional digits for Float#floor #4337

Closed
wants to merge 1 commit into from
Closed

Add optional digits for Float#floor #4337

wants to merge 1 commit into from

Conversation

@matugm
Copy link
Contributor

@matugm matugm commented Nov 26, 2016

Hey!

I implemented the 1st part of this:

  • "Float#ceil, Float#floor, and Float#truncate now take optional digits, as well as Float#round. Feature #12245"

It's my first time working on JRuby code, so I hope this is ok :)

Copy link
Member

@enebo enebo left a comment

Can you resubmit this PR against the ruby-2.4 branch? I also think you can omit your tests because that branch has test_floor_with_precision. Looks good though!

@matugm matugm changed the base branch from master to ruby-2.4 Nov 28, 2016
@matugm matugm changed the base branch from ruby-2.4 to master Nov 28, 2016
@enebo
Copy link
Member

@enebo enebo commented Nov 29, 2016

Since this is not Ruby 2.3 and we merged your other PR on 2.4 branch I am closing this one.

@enebo enebo closed this Nov 29, 2016
@headius headius modified the milestone: JRuby 9.2.0.0 Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.