Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psych to tenderlove/psych@d5757ea #434

Merged
merged 1 commit into from Dec 9, 2012

Conversation

Projects
None yet
3 participants
@atambo
Copy link
Member

atambo commented Dec 9, 2012

I would ❤️ if this got into 1.7.2 so that the transition from 1.8 mode yaml to 1.9 mode yaml is more consistent. This is basically the only thing blocking my app from switching to 1.9 mode in jruby.

There were only 3 commits since @headius last updated psych so it was pretty safe.

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Dec 9, 2012

I'd be glad to merge it if it's a release. (Assuming that the tests pass.) (cc @tenderlove)

@tenderlove

This comment has been minimized.

Copy link
Contributor

tenderlove commented Dec 9, 2012

❤️ seems good. Though I would like to get advice about future maintenance of psych. I need to figure out how to make release for JRuby in a non-painful way.

BanzaiMan added a commit that referenced this pull request Dec 9, 2012

Merge pull request #434 from atambo/master
Update psych to ruby/psych@d5757ea

OK. Let's give this a whirl. We'll discuss the future release process soon.

@BanzaiMan BanzaiMan merged commit 3d5705f into jruby:master Dec 9, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.