Remove unsafe-mock from our build altogether. #4381

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

2 participants

@headius
Member
headius commented Dec 13, 2016

This commit replaces the unsafe-mock dependency -- which caused
various build problems living in boot classpath -- with a new
library that just shims the three Unsafe methods added in Java 8:
fullFence, loadFence, and storeFence. This allows us to eliminate
all calls to those methods from JRuby proper as well as the build
tricks.

Fixes #4103.

@headius headius added this to the JRuby 9.1.7.0 milestone Dec 13, 2016
@headius
Member
headius commented Dec 14, 2016

@enebo Any objections? It does not add a dependency, but it is a new library (of one class) and it does get shaded in. I think it's worth it to eliminate the tweaky bootclasspath flags we've been passing.

@headius headius Remove unsafe-mock from our build altogether.
This commit replaces the unsafe-mock dependency -- which caused
various build problems living in boot classpath -- with a new
library that just shims the three Unsafe methods added in Java 8:
fullFence, loadFence, and storeFence. This allows us to eliminate
all calls to those methods from JRuby proper as well as the build
tricks.

Fixes #4103.
64b9553
@enebo
enebo approved these changes Dec 14, 2016 View changes

looks good to me...now I can also use debug in intellij without commenting out 3 lines!!!

@headius headius merged commit d501037 into jruby:master Dec 14, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@headius headius deleted the headius:no-unsafe-mock branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment