New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call protocol to script body and separate non-protocol metas. #4388

merged 2 commits into from Dec 15, 2016


None yet
1 participant

headius commented Dec 15, 2016

This PR adds call protocol to script bodies. This fixes recent compiler regressions caused by ripping the non-protocol logic out of CompiledIRMethod (#4382).

It appears the only scopes which do not get call protocol now are eval scopes and singleton class scopes (IRMetaClassBody). The former is never jitted and never put into CompiledIRMethod or any other context where its protocol is not already handled. The latter had its own CompiledIRMetaClassBody whose sole difference was to do pre/post call protocol, so it is renamed to reflect that.

@headius headius added this to the JRuby milestone Dec 15, 2016

Additional fixes for top-level script protocol.
* Clear StaticScope's dynscope constructor when variable names are
* Clean up jitted top-level script boot logic.

@headius headius merged commit a761edb into jruby:master Dec 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@headius headius deleted the headius:protocol-fixes branch Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment