Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
compile back to hard scope when closure compile/build requested #4392
tbh I am super bothered I cannot figure out a test case to at least occasionally fail. I explain the basic issue in #4304 (more specifically #4304 (comment)). Summarized as two threads both decide to build something and one is a child closure and the other is a parent of that closure. We get a sequence like:
This code will ask hard scope to full build itself for blocks and the two entry points to building on IRScope will built the closures before the parent. It does not appear to infinite loop so yay? I could not see anything bust with this change and I think the intent is clear but I am unsure in best particular impl to use. Part of it is based on children wanting parent info for passes vs parents wanting children info for passes.