Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubyHash's compare_by_identify Java method naming is confusing #4399

Merged
merged 1 commit into from Jan 12, 2017

Conversation

@kares
Copy link
Member

kares commented Dec 19, 2016

Hash#compare_by_identity is more of a writer (does call a setter)

... looks esp. weird since there's a java get/setCompareByIdentity

@kares kares added the internal label Dec 19, 2016
@kares
Copy link
Member Author

kares commented Dec 19, 2016

hopefully this is internal - and no one actually cares to have it the old way. but just in case, here's a PR ...

`Hash#compare_by_identity` is more of a writer (does call a setter)

... looks esp. weird since there's a java get/setCompareByIdentity
@kares kares force-pushed the kares:confusing-naming branch from a5acf19 to 8abd0f1 Dec 19, 2016
@eregon
Copy link
Member

eregon commented Dec 21, 2016

Indeed, this confused me quite a bit while looking at git log -p :)

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 7, 2017
@headius
Copy link
Member

headius commented Jan 7, 2017

👍

@kares kares merged commit 9e28f88 into jruby:master Jan 12, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kares kares modified the milestones: JRuby 9.1.8.0, JRuby 9.1.7.0 Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.