New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubyHash's compare_by_identify Java method naming is confusing #4399

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Projects
None yet
3 participants
@kares
Member

kares commented Dec 19, 2016

Hash#compare_by_identity is more of a writer (does call a setter)

... looks esp. weird since there's a java get/setCompareByIdentity

@kares kares added the internal label Dec 19, 2016

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Dec 19, 2016

Member

hopefully this is internal - and no one actually cares to have it the old way. but just in case, here's a PR ...

Member

kares commented Dec 19, 2016

hopefully this is internal - and no one actually cares to have it the old way. but just in case, here's a PR ...

RubyHash's compare_by_identify Java method naming is confusing
`Hash#compare_by_identity` is more of a writer (does call a setter)

... looks esp. weird since there's a java get/setCompareByIdentity
@eregon

This comment has been minimized.

Show comment
Hide comment
@eregon

eregon Dec 21, 2016

Member

Indeed, this confused me quite a bit while looking at git log -p :)

Member

eregon commented Dec 21, 2016

Indeed, this confused me quite a bit while looking at git log -p :)

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 7, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jan 7, 2017

Member

👍

Member

headius commented Jan 7, 2017

👍

@kares kares merged commit 9e28f88 into jruby:master Jan 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kares kares modified the milestones: JRuby 9.1.8.0, JRuby 9.1.7.0 Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment