Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StringIO thread-safe by synchronizing against ptr. #4421

Merged
merged 1 commit into from Jan 4, 2017

Conversation

@headius
Copy link
Member

@headius headius commented Jan 4, 2017

Fixes #4417.

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 4, 2017
@headius
Copy link
Member Author

@headius headius commented Jan 4, 2017

Ping @enebo, @kares for review.

@headius headius merged commit f9caf6c into jruby:master Jan 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius headius deleted the headius:stringio_threadsafe branch Jan 4, 2017
@kares
Copy link
Member

@kares kares commented Jan 5, 2017

@headius 👍, thought StringIO will be declared as non thread-safe and maybe raise ConcurrencyError as an improvement but I guess it shouldn't worsen much with single threaded use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.