New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StringIO thread-safe by synchronizing against ptr. #4421

Merged
merged 1 commit into from Jan 4, 2017

Conversation

Projects
None yet
2 participants
@headius
Member

headius commented Jan 4, 2017

Fixes #4417.

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 4, 2017

@headius

This comment has been minimized.

Show comment
Hide comment
@headius

headius Jan 4, 2017

Member

Ping @enebo, @kares for review.

Member

headius commented Jan 4, 2017

Ping @enebo, @kares for review.

@headius headius merged commit f9caf6c into jruby:master Jan 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@headius headius deleted the headius:stringio_threadsafe branch Jan 4, 2017

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Jan 5, 2017

Member

@headius 👍, thought StringIO will be declared as non thread-safe and maybe raise ConcurrencyError as an improvement but I guess it shouldn't worsen much with single threaded use.

Member

kares commented Jan 5, 2017

@headius 👍, thought StringIO will be declared as non thread-safe and maybe raise ConcurrencyError as an improvement but I guess it shouldn't worsen much with single threaded use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment