Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill the LocalJumpError logic for break in lambda. Fixes #4369. #4423

Merged
merged 1 commit into from Jan 11, 2017

Conversation

@headius
Copy link
Member

headius commented Jan 6, 2017

This is a complete removal of the error logic, but it did not fail the suites I ran locally. Open for comments or concerns @enebo @subbuss.

@headius
Copy link
Member Author

headius commented Jan 7, 2017

I kicked the one job that failed, but this looks like it's ok.

@headius headius added this to the JRuby 9.1.7.0 milestone Jan 7, 2017
@headius headius added ir jit labels Jan 7, 2017
@subbuss
Copy link
Contributor

subbuss commented Jan 9, 2017

If CI is happy and no one can actually come up with an error case, I suppose the existing semantics in JRuby is probably 1.8 or 1.9 and no longer relevant?

@enebo enebo modified the milestones: JRuby 9.1.8.0, JRuby 9.1.7.0 Jan 11, 2017
@enebo enebo merged commit ff19740 into jruby:master Jan 11, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.