[#4353] Ignore consecutive DOUBLE_STAR in glob_helper. #4428

Merged
merged 4 commits into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@sumitmah

sumitmah commented Jan 7, 2017

No description provided.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Jan 10, 2017

Member

najs! any chance for a cleanup or even better use Dir.tmpdir as a base so we do not have to worry about?

Member

kares commented Jan 10, 2017

najs! any chance for a cleanup or even better use Dir.tmpdir as a base so we do not have to worry about?

@sumitmah

This comment has been minimized.

Show comment
Hide comment
@sumitmah

sumitmah Jan 10, 2017

@kares In the tests you're asking?

@kares In the tests you're asking?

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Jan 11, 2017

Member

yeah just whatever to cleanup the created dirs e.g. an ensure FileUtils.rm_r 'testDir_bug4353'

Member

kares commented Jan 11, 2017

yeah just whatever to cleanup the created dirs e.g. an ensure FileUtils.rm_r 'testDir_bug4353'

@sumitmah

This comment has been minimized.

Show comment
Hide comment

@kares done!

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Jan 11, 2017

Member

@sumitmah thank you!
@headius @enebo this seems good to go for 9.1.7 ... need another set of eyes to confirm.

Member

kares commented Jan 11, 2017

@sumitmah thank you!
@headius @enebo this seems good to go for 9.1.7 ... need another set of eyes to confirm.

@kares kares added the core label Jan 11, 2017

@kares kares added this to the JRuby 9.1.7.0 milestone Jan 11, 2017

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jan 11, 2017

Member

@kares I would prefer to wait on this one since it has been wrong since the beginning of JRuby and we can just merge right after 9.1.7.0.

Member

enebo commented Jan 11, 2017

@kares I would prefer to wait on this one since it has been wrong since the beginning of JRuby and we can just merge right after 9.1.7.0.

@kares

This comment has been minimized.

Show comment
Hide comment
@kares

kares Jan 11, 2017

Member

@enebo np, your call

Member

kares commented Jan 11, 2017

@enebo np, your call

@enebo enebo modified the milestones: JRuby 9.1.8.0, JRuby 9.1.7.0 Jan 11, 2017

@enebo enebo merged commit bbd0440 into jruby:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment