Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4353] Ignore consecutive DOUBLE_STAR in glob_helper. #4428

Merged
merged 4 commits into from Jan 11, 2017

Conversation

@sumitmah
Copy link

sumitmah commented Jan 7, 2017

No description provided.

@sumitmah sumitmah force-pushed the sumitmah:4353-fix-dir-glob branch from 9b5135c to 53593e8 Jan 10, 2017
@sumitmah sumitmah force-pushed the sumitmah:4353-fix-dir-glob branch from aca8fee to b8edd91 Jan 10, 2017
@kares
Copy link
Member

kares commented Jan 10, 2017

najs! any chance for a cleanup or even better use Dir.tmpdir as a base so we do not have to worry about?

@sumitmah
Copy link
Author

sumitmah commented Jan 10, 2017

@kares In the tests you're asking?

@kares
Copy link
Member

kares commented Jan 11, 2017

yeah just whatever to cleanup the created dirs e.g. an ensure FileUtils.rm_r 'testDir_bug4353'

@sumitmah
Copy link
Author

sumitmah commented Jan 11, 2017

@kares done!

@kares
Copy link
Member

kares commented Jan 11, 2017

@sumitmah thank you!
@headius @enebo this seems good to go for 9.1.7 ... need another set of eyes to confirm.

@kares kares added the core label Jan 11, 2017
@kares kares added this to the JRuby 9.1.7.0 milestone Jan 11, 2017
@enebo
Copy link
Member

enebo commented Jan 11, 2017

@kares I would prefer to wait on this one since it has been wrong since the beginning of JRuby and we can just merge right after 9.1.7.0.

@kares
Copy link
Member

kares commented Jan 11, 2017

@enebo np, your call

@enebo enebo modified the milestones: JRuby 9.1.8.0, JRuby 9.1.7.0 Jan 11, 2017
@enebo enebo merged commit bbd0440 into jruby:master Jan 11, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.