Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set toplevel module #4431

Merged
merged 2 commits into from Jan 9, 2017
Merged

Set toplevel module #4431

merged 2 commits into from Jan 9, 2017

Conversation

@headius
Copy link
Member

@headius headius commented Jan 9, 2017

This includes a fix for #4416 (setting top-level module when running with -X+C) and enables the test:jruby:aot suite to verify the AOT mode.

headius added 2 commits Jan 9, 2017
The logic that precompiles a 'load'ed or 'require'd file did not
ever call setModule or determineModule on the root scope for that
script body. This caused module definitions to blow up, since they
had no containing scope in which to define the new module.
@headius headius added the jit label Jan 9, 2017
@headius headius added this to the JRuby 9.1.7.0 milestone Jan 9, 2017
@headius headius merged commit 2d090fb into jruby:master Jan 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@headius headius deleted the headius:set-toplevel-module branch Jan 9, 2017
@kares
Copy link
Member

@kares kares commented Jan 10, 2017

excellent, wanted to add test:jruby:aot as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.